[Stk] Bug in ADSR.setAllTimes decay rate?

[Zacko Belsch]

Sounds reasonable.  The issue for a new user would be that other
descriptions of the ADSR concept (not as specific to SDK) generally
describe decay as time from full to sustain.

Would it be useful to add a note to the ADSR class description indicating
something along the lines of Perry's latest description?  Currently the
description at
https://ccrma.stanford.edu/software/stk/classstk_1_1ADSR.html#a3567b02a0e8ab82d18eb949d362f9708
just says that time settings are in seconds and must be positive, but gives
no indication of the semantic meaning of decay or release times.  In the
current implementation decay is interpreted as time to go from full to
one-half (more correctly, from full to the previous sustain) and release is
the time to go from new sustain to zero.  A brief note there could help new
users, who can easily just call the individual set routines
(.setAttackTime, etc.) to get decay that corresponds to time from full to
sustain (providing they set sustain before they set decay).

Bob H
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://ccrma-mail.stanford.edu/pipermail/stk/attachments/20140120/0de29f60/attachment.html