[Stk] Possible ADSR or Wurley bug

[Gary Scavone]

Hi Joseph,

A fix for this was just provided by Nick Donaldson (attached below).  Strange that a bug that has long-existed should suddenly be found by two different people within a week!

--gary

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ADSR.cpp
Type: application/octet-stream
Size: 4252 bytes
Desc: not available
Url : http://ccrma-mail.stanford.edu/pipermail/stk/attachments/20101007/70665af9/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ADSR.h
Type: application/octet-stream
Size: 4084 bytes
Desc: not available
Url : http://ccrma-mail.stanford.edu/pipermail/stk/attachments/20101007/70665af9/attachment-0001.obj 
-------------- next part --------------


On 2010-10-07, at 12:49 PM, Joseph Cooper wrote:

> The Wurley instrument, by default, sets its 4 ADSR envelopes with a
> sustain level of zero.  The release rate of the ADSR is calculated as
> a function of the sustain level, perhaps because of this previous
> post: http://ccrma-mail.stanford.edu/pipermail/stk/2003-May/000104.html
> In its current state, this means that releaseRate_ = 0 if
> sustainLevel_ == 0.  Consequently, if you choose to release a note
> before it has faded all the way to zero (i.e., with noteOff or
> keyOff), then the envelope goes into release state, but never decays
> from its current level.  The work-arounds are obvious, but it seemed
> worth noting the phenomenon since it took me some code digging to
> figure out why my notes didn't stop when I let go of the key.
> 
> jc
> 
> _______________________________________________
> Stk mailing list
> Stk at ccrma.stanford.edu
> http://ccrma-mail.stanford.edu/mailman/listinfo/stk